Drop Scala 2.12 support #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove scala-2.12- version-specific source directories - Update build.sbt to only support Scala 2.13 and 3.3.4 - Update CI workflow to remove 2.12 from test matrix - Use Scala 2.13+ APIs (IterableOnce, jdk.CollectionConverters) BREAKING: Scala 2.12 is no longer supported. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move nested class definitions outside test methods for Scala 3 compatibility: - ClosureCleanerAdditionalSpec: Move test helper classes to class level and companion object to avoid NoClassDefFoundError in Scala 3 - ExternalizerAdditionalSpec: Add explicit type annotations for heterogeneous collections to avoid type inference issues in Scala 3 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use explicit type parameters Map[String, Any] and Externalizer[Map[String, Any]] to avoid Scala 3 type inference issues while maintaining original test coverage. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Breaking Change
BREAKING: Scala 2.12 is no longer supported. Users must upgrade to Scala 2.13 or 3.x.
Test plan
Note: Scala 3 test compilation has pre-existing issues unrelated to this change.
🤖 Generated with Claude Code